Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of popup changed in some cases when text is often completly removed and re-added #22

Closed
rugk opened this issue Apr 18, 2018 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rugk
Copy link
Owner

rugk commented Apr 18, 2018

When you delete all text and only input one letter, delete it again, input again, etc. it often happens that the popup window is re-sized 5px or so for each new "showing" of that window. After some "cycles" it seems to end/to be limited though.
The reason seems to be the placeholder, which is shown and hidden by the JS if everything is removed there.

Actually the underlying problem is, that the whole thing (textarea) jumps/resizes itself when it is hidden. Although the element has it's width and height clearly set (otherwise it would also collapse when no element is inside of it.). Here is a GIF where I just hide it (no other change!):

classvisibilitycausesproblems

It does not matter whether I hide the SVG placeholder or the Canvas, it's both the same.

It even happens, when only the alt text is displayed:
classvisibilitycausesproblemsalttext

It is reproducible in Firefox 60 and without JS:
classvisibilitycausesproblemswithoutjs

Maybe it is also a Firefox bug?

@rugk rugk added the bug Something isn't working label Apr 18, 2018
@rugk rugk added this to the 1.1 milestone Apr 18, 2018
@rugk rugk self-assigned this Apr 18, 2018
@rugk
Copy link
Owner Author

rugk commented Apr 22, 2018

Should be fixed in 1.1/current master.

@rugk rugk closed this as completed Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant