Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust and group options style with headers like Firefox #43

Closed
rugk opened this issue Apr 23, 2018 · 2 comments · Fixed by #170
Closed

Adjust and group options style with headers like Firefox #43

rugk opened this issue Apr 23, 2018 · 2 comments · Fixed by #170
Labels
enhancement New feature or request
Milestone
1.6

Comments

@rugk
Copy link
Owner

rugk commented Apr 23, 2018

Using about:preferences as a template, the aim should be to have something simlar from a grouping perspective.

This also means to drop fieldsets (the border around the radio options as a "radio group").

See https://design.firefox.com/photon/visuals/grid.html
@rugk rugk added the enhancement New feature or request label Apr 23, 2018
@rugk rugk mentioned this issue Apr 23, 2018
Open
@ongspxm
Copy link
Contributor

ongspxm commented Mar 7, 2019

hmm... any work to be done on this? what do u mean grouping perspective?

@rugk
Copy link
Owner Author

rugk commented Mar 7, 2019

No, this is still to be solved…

What I mean is best explained on https://design.firefox.com/photon/visuals/grid.html#spacing. I just want to group the options into some useful categories…
When you want to take this on, just make sure you follow the above linked Firefox Photon style exactly. 😄

As said about:preferences can be used as a visual template, i.e. it should look similar to there.

@ongspxm ongspxm mentioned this issue Mar 14, 2019
Merged
@rugk rugk closed this as completed in #170 Apr 2, 2019
rugk added a commit that referenced this issue Apr 2, 2019
@rugk
Merge branch 'pr-170/ongspxm/optstyle'
8eed0e1 
Fixes #43
@rugk rugk mentioned this issue Apr 2, 2019
Open
@rugk rugk added this to the 1.6 milestone Apr 2, 2019
@Cye3s Cye3s mentioned this issue Apr 2, 2019
Closed
@rugk rugk mentioned this issue Apr 12, 2019
Closed
daaAd1 pushed a commit to daaAd1/offline-qr-code that referenced this issue Sep 30, 2019
@rugk
Merge branch 'pr-170/ongspxm/optstyle'
73566a6 
Fixes rugk#43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6
Development

Successfully merging a pull request may close this issue.

Adjust and group options style with headers like Firefox #43 ongspxm/offline-qr-code
2 participants
@ongspxm @rugk