Issue 173 - Credit translator

[R3ddingt0n]

Fixes Issue #173

Well this seems to work.
I am sure there are still many improvements to do, so if there's something I can do, let me know 😉

Example with browser configured in french :

Example with browser configured in german, where the english text is shown :

[rugk]

Thanks. I've changed the styling a little and fixed some issues in the Localizer lib. Also added the English example and adjusted the text/i18n selectors.

This is how it looks now:

BTW, also written the corresponding doc for this at https://github.com/TinyWebEx/common/blob/master/CONTRIBUTING.md#translator-credit-inside-of-add-on

[rugk]

So still TODO:

• translate the German text and test it (/me will do)
• adjust French text/translation and test it (@nicolas-trouin)

[rugk]

BTW to (automatically) let issues close when a PR is merged, write "fixes" before the issue number (in your heading here).

[rugk]

BTW, after this is merged, and if you also want to do the same PR for the other add-ons (backlinks above this comment), then feel free to do so… 😄

[R3ddingt0n]

BTW, after this is merged, and if you also want to do the same PR for the other add-ons (backlinks above this comment), then feel free to do so… 😄

I'll check it out ^^'

[R3ddingt0n]

French translation

Is that fine ?

I also spotted a spacing problem with the english translation, as shown below :

Should I try to solve it ?

[rugk]

Likely you just need to run git submodule update to sync the submodules to the new state I have commit them… (bad git does not do this automatically)

(Because that did not happen in my case.)

[R3ddingt0n]

Likely you just need to run git submodule update to sync the submodules to the new state I have commit them… (bad git does not do this automatically)

(Because that did not happen in my case.)

Yep that solved the problem. Anything else I can do about the french translation or other ?

[rugk]

I can do about the french translation or other ?

I don't know whether it's still the case, but there likely should not be a space before the ! at the end of the sentence.

[R3ddingt0n]

I don't know whether it's still the case, but there likely should not be a space before the ! at the end of the sentence.

Well, I think you'd be right for English or German, but in French there has to be a single space before and after "!", "?", ";", and maybe others too.

[rugk]

BTW, after this is merged, and if you also want to do the same PR for the other add-ons (backlinks above this comment), then feel free to do so… smile

I'll check it out ^^'

BTW, let me know in rugk/awesome-emoji-picker#18 and rugk/mastodon-simplified-federation#25 if you want to solve that. 😄