Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Level #27

Closed
lgrahl opened this issue Dec 25, 2015 · 8 comments
Closed

Feature Level #27

lgrahl opened this issue Dec 25, 2015 · 8 comments

Comments

@lgrahl
Copy link

lgrahl commented Dec 25, 2015

We (Theema and I) have discussed using feature levels instead of having the same version numbers for different SDK languages. You can see the current definition below:

The feature level will be represented as a constant in the source code of the respective SDK. It should be printed, alongside the version number, when invoking the command line interface with the flag -v or --version. Alternatively, a command called version can be used instead of the flag.

Level Text Capabilities Image File Credits
1 X
2 X X X X
3 X X X X X

(The implementations for the official Java and PHP SDK are still missing, though.)

@rugk
Copy link
Owner

rugk commented Dec 25, 2015

Okay, good idea. AFAIK the PHP SDK is at level 3.

@rugk
Copy link
Owner

rugk commented Feb 28, 2016

@lgrahl Do you know when Threema wants to implement it in the PHP/Java SDK?

/cc @simmac

@lgrahl
Copy link
Author

lgrahl commented Feb 28, 2016

Nope. We may have to remind them. @threema-ch

@rugk
Copy link
Owner

rugk commented Feb 28, 2016

I doubt they react to mentions on GitHub...

@simmac
Copy link

simmac commented Feb 28, 2016

@lgrahl @rugk I will do that as I have to contact Threema anyway regarding my fork of the java-sdk.

@rugk
Copy link
Owner

rugk commented Feb 28, 2016

@simmac Thanks.

simmac added a commit to simmac/threema-msgapi-sdk-java that referenced this issue Feb 28, 2016
… -v`) with feature level (also explained in [rugk/threema-msgapi-sdk-php/issues/27](rugk/threema-msgapi-sdk-php#27) ).

NOTE: This is an unofficial implementation in the community edition of the Threema msg-API which has been forwarded to Threema for an official implementation.
@simmac
Copy link

simmac commented Feb 28, 2016

@rugk @lgrahl @threema-ch
I just committed my own implementation of the version and feature level command in the Java-API: 7da9286.

@rugk rugk closed this as completed in 08cf950 Sep 18, 2016
@rugk
Copy link
Owner

rugk commented Sep 18, 2016

Implemented:
featurelevel

But it only works with -v and no other switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants