-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not replace <-- --> and other certain characters in Markdown/HTML #14
Comments
Note that HTML comments are
This would be tricky to implement, as you would need to detect any preceding
Yeah, you could detect if the user is typing in a |
Oh of course |
Yes, that would be a possible workaround for most websites. Although like you said, it would have no effect on GitHub since it uses |
So… @tdulcet do you think that’s a good solution then to implement? Given it won’t work on GitHub (also not in the text editor), we have a huge user base of devs and so on there, which will definitively be annoyed by that “feature”, so hmm… I'm not sure. |
Sure, we could add this as an option at least, probably disabled by default. Although I am not sure how difficult this would be to implement or if it would have any performance impacts.
We could also allow users to blacklist domains/websites, although disabling autocorrections on all of GitHub would obviously not be a good solution either. This would also require TinyWebEx/AutomaticSettings#15. |
Bug description
Let's take our issue templates here that make a lot of use of HTML comments, i.e.
-->
.I was confused when editing issues here that some of my comments
Steps to reproduce
<-- todo -->
.Actual behavior
The comment is converted to this:
⟵ todo ⟶
.Especially in a non same-width text like on GitHub here (⟵ todo ⟶) this is really subtle to spot and breaks the whole text as much of it is now commented, as the comment never ends.
Expected behavior
Replacing this with an arrow (⟵, ⟶) is never intended here, so a workaround would be good to find here.
It must not replace this.
System
Operating system and version: Linux/Fedora 33
Browser and version: Firefox 83
Add-on version: bb913b0
Further comments
The same applied maybe to
----
for making a horizontal line in Markdown, it is also replaced and thus breaks Markdown.Possible solution
<--
?The text was updated successfully, but these errors were encountered: