Update README.md #1170
Open
Update README.md #1170
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC doesn't accept a path as an argument to `-fuse-ld`. `-fuse-ld=mold` is enough. Tested with ``` gcc (GCC) 13.2.1 20231205 (Red Hat 13.2.1-6) ```
pothos
reviewed
May 19, 2024
| @@ -143,7 +143,7 @@ may be able to remove the `linker = "clang"` line. | |||
|
|
|||
| ```toml | |||
| [target.x86_64-unknown-linux-gnu] | |||
| rustflags = ["-C", "link-arg=-fuse-ld=/path/to/mold"] | |||
| rustflags = ["-C", "link-arg=-fuse-ld=mold"] | |||
There was a problem hiding this comment.
It seems that gcc doesn't support the path, hence I would change may be able to remove the 'linker = "clang"' line. to may be able to remove the 'linker = "clang"' line and change the '-fuse-ld=' setting to 'mold'., i.e., add and change the '-fuse-ld=' setting to 'mold'. to the before paragraph.
When one just reads the instructions it sounds like one would only remove that linker = "clang" line, so making it a bit more explicit would be nice. (I see that a few paragraphs before it is mentioned that GCC does not take an absolute path.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC doesn't accept a path as an argument to
-fuse-ld. It errors out byPassing
-fuse-ld=moldis enough.Tested with