Feat: use accumulate address on sections with SHT_NOBITS #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokblast
changed the title
|
After all, I can strip and run the binary after strip |
|
Isn't it more like a bug in bsd's strip than that in mold? |
|
I don't know but I have tested on gold, lld, and bfd. They all have same behaviors. I think we should not call it a bug. It is an ambiguity on the design of ELF format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix the bug in #456.
The reason is caused by the offset of sections with SHT_NOBITS.
As the following picture shows:
The left side is the output of mold and the right side is the output of lld. We can see that file offset of the sections with SHT_NOTIBS is all zero in mold. This cause the sections enter this
functionin FreeBSD strip returnedunloaded=0thus discard in the segment as the second picture shows.This pictures .bss is discarded in left side.