Fix string ctor param from strstr #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui314
force-pushed
the
main
branch
5 times, most recently
from
4d1a1bd
to
a0a94f4
Compare
rui314
force-pushed
the
main
branch
4 times, most recently
from
ae0019b
to
3fab4ce
Compare
|
Thank you for your patch! Could you read https://github.com/rui314/mold/blob/main/CONTRIBUTING.md and add a Signed-off-by line to your commit message? |
When using the (begin, end) constructor for string, the types of begin and end must match, including cv qualifiers. Depending on the library headers used, strstr(const char *, const char *) can potentially return char * or const char *, the former being a call to the C function strstr and the latter being a call to C++ std::strstr. This commit fixes the clang portion of issue rui314#21, by explicitly casting the return value of strstr to match the 1st param of the string ctor so that the ctor can be instantiated regardless of the header used. Signed-off-by: Jim Ye <gjimye@gmail.com>
gjimye
force-pushed
the
fix/string-constructor-type-error
branch
from
00dafd1
to
9c304f7
Compare
Done, thanks! |
|
Thanks! I merged your commit. You are the first contributor to this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the (begin, end) constructor for string, the types of begin
and end must match, including cv qualifiers. Depending on the library
headers used, strstr(const char *, const char *) can potentially return
char * or const char *, the former being a call to the C function strstr
and the latter being a call to C++ std::strstr.
This commit fixes the clang portion of issue #21, by explicitly casting
the return value of strstr to match the 1st param of the string ctor so
that the ctor can be instantiated regardless of the header used.