(WIP) use debuginfo for undefined references #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luboš Luňák <l.lunak@centrum.cz>
Signed-off-by: Luboš Luňák <l.lunak@centrum.cz>
When reporting undefined references, first try to search debuginfo for the actual source location of where the reference comes from, i.e. the line/column and possibly header file. DWARFv5 filenames are not supported yet. Since debuginfo needs to be relocated to be usable (otherwise various references between different debug sections do not work), so the reporting now needs to be done later (to be improved). Signed-off-by: Luboš Luňák <l.lunak@centrum.cz>
|
I honestly feel that this is a bit too much code and complexity just to show the line number for an undefined symbol reference. After all, we just want to know the line number, but unfortunately DWARF is too complicated that that doesn't allow us to do that easily. It is usually easy for me to identify a location of an undefined reference without a line number, so I didn't personally find it that useful. |
rui314
force-pushed
the
main
branch
3 times, most recently
from
ccf2cda
to
7d91674
Compare
rui314
force-pushed
the
main
branch
2 times, most recently
from
bf2c440
to
df9e997
Compare
rui314
force-pushed
the
main
branch
3 times, most recently
from
cc86039
to
25d02bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unfinished work that tries to use debuginfo to report source locations of places that cause undefined references, rather than just the object file. The reason I'm submitting this unfinished version is that debuginfo requires relocating to be usable, otherwise references between sections do not work (relocations include also offsets within the section, and without relocations those values are 0, pointing to incorrect places in the debuginfo data in the .o file).
The debuginfo relocations need to be done somewhere, and currently it's done while writing the entire output file, so for now the patch delays reporting the undefined symbols until after that, since currently molds always processes the entire file even if there are errors. But you reverted the delayed processing of undefined references, and I don't know if it's possible to process debuginfo and its relocations before non-delayed undefined references handling. This changeset reverts the revert for simplicity, but I don't want to change the code back to delayed if you'd change it back yet again, so I wanted to ask for feedback on this.