Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RV32] Skip all test cases not applicable to RV32 #670

Merged
merged 1 commit into from Aug 28, 2022

Conversation

ksco
Copy link
Contributor

@ksco ksco commented Aug 27, 2022

Along with #669, all test cases for RV32 are passed.

@ksco ksco changed the title [RV32] Skip local label check in strip test case [RV32] Skip all test cases not applicable to RV32 Aug 27, 2022
@rui314
Copy link
Owner

rui314 commented Aug 27, 2022

I don't think adding -L/usr/riscv32-linux-gnu to the command line is the right thing to do. Other targets don't need -L /usr/target-name. I think you should compile your compiler so that the path is automatically added to the library search path.

Signed-off-by: Yang Liu <liuyang22@iscas.ac.cn>
@ksco
Copy link
Contributor Author

ksco commented Aug 28, 2022

OK, I've dropped all relevant changes. Also, adding CI for RV32 in GitHub Action doesn't seem to be very easy since gcc-10-riscv32-linux-gnu package is not available in Ubuntu.

@rui314 rui314 merged commit 0a4586a into rui314:main Aug 28, 2022
@ksco ksco deleted the rv32gc-strip-fix branch August 28, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants