Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options column, row, lang "zh_tw" are ignored #136

Closed
kimgysen opened this issue Dec 20, 2022 · 5 comments
Closed

Options column, row, lang "zh_tw" are ignored #136

kimgysen opened this issue Dec 20, 2022 · 5 comments

Comments

@kimgysen
Copy link

kimgysen commented Dec 20, 2022

Describe the bug
Options column, row, lang "zh_tw" are ignored

To Reproduce
Steps to reproduce the behavior:

  1. Try to fill in any number for column or row, also set lang option "zh_tw"
  2. Column / row count is still the default, despite options passed. Language zh_tw render English context menu

Expected behavior
For the documented options to work as advertised.

Screenshots
image

Additional context
I see that this sandbox uses an old version, but it's the same in the latest that I installed today.

@kimgysen
Copy link
Author

kimgysen commented Dec 20, 2022

rowHeaderWidth and columnHeaderHeight don't appear to be doing anything either when changing the values.
Setting the values to zero doesn't hide them.

@kimgysen
Copy link
Author

kimgysen commented Dec 20, 2022

I also think that the default fontSize has changed to 10 in the latest version from 11 in previous, so perhaps the docs need to be updated.
I don't think that setting the defaultFontSize works either, unless I'm just doing a bunch of wrong things:

image

image

As a sidenote, I noticed that the allowEdit option is missing from the docs.

Just fyi, I'm not here to annoy you guys. I'm working on some hobby-prototype-project to create React demos through configurable options:

image

This is why it just happened to be your project and I'm running through the configurable options.

@jikoczl
Copy link
Contributor

jikoczl commented Dec 20, 2022

you should use lang="zh-TW", not zh_tw. But, We haven't added zh-TW translation for some of the new features.

@shuanhukexuejia
Copy link
Collaborator

  • The issue about row/column options has been fixed in fix: some bugs #124 and it will work fine in next version
  • Other config do have some problem, will look into it.

@shuanhukexuejia
Copy link
Collaborator

shuanhukexuejia commented Dec 22, 2022

  • fixed the issue of rowHeaderWidth/columnHeaderHeight in fix: default settings #141
  • DefaultFontSize works, you can set it to 25 to see the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants