Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly process ct.s array in getCellValue #541

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ErnestThePoet
Copy link
Contributor

@ErnestThePoet ErnestThePoet commented Apr 24, 2024

If a cell's content is composed of parts with different styles, Cell.ct.s can be an array with multiple elements. However, current getCellValue API only extracts the first content part from s array. In order to retrieve full content, values in s array should be concatenated.

@sanchit3008
Copy link
Collaborator

thanks for catching this @ErnestThePoet !

@sanchit3008 sanchit3008 merged commit ce44455 into ruilisi:master Apr 24, 2024
1 check passed
@ErnestThePoet ErnestThePoet deleted the fix/getCellValue-ct.s branch April 25, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants