Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package dependencies #30

Closed
victorocna opened this issue Oct 16, 2020 · 2 comments
Closed

Package dependencies #30

victorocna opened this issue Oct 16, 2020 · 2 comments

Comments

@victorocna
Copy link
Contributor

Hello everyone!

I was browsing package.json and found some possible tweaks:

  • move react-scripts to devDependencies (from dependencies)
  • move react to peerDependencies (from devDependencies)
  • add prop-types (used in the project) to peerDependencies

What do you think? I've tested in on my machine and it did not break the build process.
I can write a PR with these changes, if you think they are all right.
@fybchristasker
Copy link
Contributor

@victorocna Welcome to give PR, if your are interested.

@victorocna victorocna mentioned this issue Nov 25, 2020
Merged
@hophacker
Copy link
Contributor

#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hophacker @victorocna @fybchristasker