Replace request-debug with request-logger
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobranco
force-pushed
the
bugfix/fix-modifying-by-reference
branch
8 times, most recently
from
0a5f749
to
937d225
Compare
ruimarinho
requested changes
Jan 12, 2017
|
|
||
| export function obfuscate(request) { | ||
| // Obfuscate the API key on `uri`. | ||
| if (request.uri) { |
There was a problem hiding this comment.
When can request.uri be undefined?
| export function obfuscate(request) { | ||
| // Obfuscate the API key on `uri`. | ||
| if (request.uri) { | ||
| request.uri = (request.uri || '').replace(replacement, '$1*****'); |
There was a problem hiding this comment.
Why coalesce to an empty string here? What other shapes can .uri have?
|
|
||
| // Obfuscate the API key on `body`. | ||
| if (request.body && _.isString(request.body)) { | ||
| request.body = (request.body || '').replace(replacement, '$1*****'); |
There was a problem hiding this comment.
If you're already testing if request.body is a string, which coalesce to an empty string?
pedrobranco
force-pushed
the
bugfix/fix-modifying-by-reference
branch
from
937d225
to
c815412
Compare
ruimarinho
reviewed
Jan 12, 2017
| * Module dependencies. | ||
| */ | ||
|
|
||
| import _ from 'lodash'; |
ruimarinho
reviewed
Jan 12, 2017
| body: 'foo=bar?api_key=foobar', | ||
| id: '354f8341-eb27-4c91-a8f7-a30e303a0976', | ||
| method: 'GET', | ||
| uri: 'foo=bar?api_key=foobar' |
ruimarinho
reviewed
Jan 12, 2017
| * Module dependencies. | ||
| */ | ||
|
|
||
| import _ from 'lodash'; |
There was a problem hiding this comment.
import { defaults } for consistency?
pedrobranco
force-pushed
the
bugfix/fix-modifying-by-reference
branch
from
c815412
to
ef43342
Compare
pedrobranco
force-pushed
the
bugfix/fix-modifying-by-reference
branch
from
ef43342
to
b78435d
Compare
ruimarinho
approved these changes
Jan 12, 2017
|
Thank you for the PR. This looks awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12 and also removes the custom request serializer for
debugnyan, and handles it directly before logging todebugnyan.