Replace api_key querystring or body parameter by more secure header #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixe
reviewed
Jan 24, 2017
| @@ -64,11 +64,16 @@ export default class Client { | |||
|
|
|||
| this.rpc = Promise.promisifyAll(request.defaults(_.defaultsDeep({ | |||
| baseUrl: `${this.host}/protected/json/`, | |||
| qs: { api_key: this.key } | |||
| headers: { | |||
ruimarinho
force-pushed
the
enhancement/use-authy-api-key-header
branch
from
8339e1c
to
9a48cb1
Compare
ruimarinho
force-pushed
the
enhancement/use-authy-api-key-header
branch
from
9a48cb1
to
26befd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Authy finally migrated away from the querystring/body parameter
api_keyand now uses an header for authentication.