Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

something not working #1

Closed
jrhaberstroh opened this issue Oct 27, 2016 · 2 comments
Closed

something not working #1

jrhaberstroh opened this issue Oct 27, 2016 · 2 comments

Comments

@jrhaberstroh
Copy link

I tried forking this repo and adding a meanvar procedure, but it did not work. I went back and tried to produce an elbow plot for one of the other procedures (var), but that had an erratic shape. I think there is something wrong with the core of this program. It should be A/B tested against the R package to really figure out if it is functioning.

@ruipgil
Copy link
Owner

ruipgil commented Oct 29, 2016

I’m going to take a closer look soon.

On 27 Oct 2016, at 21:19, John H. notifications@github.com wrote:

I tried forking this repo and adding a meanvar procedure, but it did not work. I went back and tried to produce an elbow plot for one of the other procedures (var), but that had an erratic shape. I think there is something wrong with the core of this program. It should be A/B tested against the R package to really figure out if it is functioning.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #1, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6I0rIJsZmxcnp8f-BUYFQGnoA3fkt6ks5q4QdLgaJpZM4Kix6W.

@ruipgil
Copy link
Owner

ruipgil commented Oct 30, 2016

There was a bug in the main code that should be fixed.
I've also implemented the meanvar cost function.

Let me know if you still encounter the same issue, or if it's resolved.

@ruipgil ruipgil closed this as completed Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants