Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private code from public libWrapper scope #16

Closed
ruipin opened this issue Feb 9, 2021 · 2 comments
Closed

Remove private code from public libWrapper scope #16

ruipin opened this issue Feb 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ruipin
Copy link
Owner

ruipin commented Feb 9, 2021

Currently, the global libWrapper class exposes a lot of underlying code (methods that start with _) that probably shouldn't be available in global scope.

If I have some time, it might be useful to move these methods off to a private scope that is not exposed to the world. Additionally, it might make sense for the release versions to minify any method name starting in _.

@ruipin ruipin added the enhancement New feature or request label Feb 9, 2021
@ruipin ruipin changed the title Remove private code from libWrapper scope Remove private code from public libWrapper scope Feb 9, 2021
@ruipin
Copy link
Owner Author

ruipin commented Apr 3, 2021

As discussed in #28, the module "Better Rolls" is accessing private APIs they probably shouldn't. As such, this issue is essentially blocked by that one, and any changes here will need to be discussed with them, otherwise their module will break.

ruipin added a commit that referenced this issue Apr 9, 2021
ruipin added a commit that referenced this issue Apr 9, 2021
@ruipin ruipin closed this as completed in 68bb897 Apr 11, 2021
@ruipin
Copy link
Owner Author

ruipin commented Apr 11, 2021

This is now done in v1.4.0.0, closing.

Better Rolls has also been updated to use the newly documented API discussed in #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant