Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data loss aften an orientation change. #195

Open
aalmds opened this issue Jan 15, 2022 · 2 comments · Fixed by #197 · May be fixed by #196
Open

Data loss aften an orientation change. #195

aalmds opened this issue Jan 15, 2022 · 2 comments · Fixed by #197 · May be fixed by #196
Assignees
@ruleant
Labels
bug priority medium
Milestone
v0.9

Comments

@aalmds
Copy link

aalmds commented Jan 15, 2022

When an orientation change happens, the dialog that is been displayed in the screen disappears.

One test case that can exemplify that is:
1 - Open the app.
2 - Click on "Store Location" button.
3 - Double rotate the screen.

After the rotation, the activity is recreated and the current dialog is missed.

XRecorder_15012022_185630.1.mp4

Informations:
Device: Galaxy J6 (OS Android 10)
Version: v0.9-dev
aalmds added a commit to aalmds/getback_gps that referenced this issue Jan 15, 2022
@aalmds
Solving data loss issue ruleant#195
d28c097
@aalmds aalmds linked a pull request Jan 15, 2022 that will close this issue
Open
@ruleant
Copy link
Owner

ruleant commented Jan 19, 2022

Cool, nice find @aalmds!
Thanks for reporting and suggesting a fix. I'll review them soon. :)

@ruleant ruleant added this to the v0.9 milestone Jan 19, 2022
@ruleant ruleant self-assigned this Jan 19, 2022
@ruleant ruleant linked a pull request Jan 19, 2022 that will close this issue
Solving data loss issue #195 #196
Open
janScheible added a commit to janScheible/forked-getback_gps that referenced this issue Jan 28, 2022
@janScheible
Data loss aften an orientation change. ruleant#195
f0afd50 
- store view state in bundle
janScheible added a commit to janScheible/forked-getback_gps that referenced this issue Jan 28, 2022
@janScheible
Data loss aften an orientation change. ruleant#195
0043587 
- fix of 'Document empty method body' from https://app.codacy.com/gh/ruleant/getback_gps/pullRequest?prid=8792030
- covered one more corner case: dialog was opened and device was rotated without started typing --> will still re-open the dialog after a config change
janScheible added a commit to janScheible/forked-getback_gps that referenced this issue Jan 28, 2022
@janScheible
Data loss aften an orientation change. ruleant#195
a9305c3 
- introduced a constant for the bundle key
@ruleant ruleant mentioned this issue Jan 31, 2022
Merged
janScheible added a commit to janScheible/forked-getback_gps that referenced this issue Feb 5, 2022
@janScheible
Data loss aften an orientation change. ruleant#195
d7bffea 
- extracted the state tracking to a custom dialog builder class (StateTrackingDialogBuilder), works now for all 3 dialogs
janScheible added a commit to janScheible/forked-getback_gps that referenced this issue Feb 5, 2022
@janScheible
Data loss aften an orientation change. ruleant#195
b8d7289 
- fixes for https://app.codacy.com/gh/ruleant/getback_gps/pullRequest?prid=8792030
janScheible added a commit to janScheible/forked-getback_gps that referenced this issue Feb 5, 2022
@janScheible
Data loss aften an orientation change. ruleant#195
4a32abc 
- fixes for https://app.codacy.com/gh/ruleant/getback_gps/pullRequest?prid=8792030
janScheible added a commit to janScheible/forked-getback_gps that referenced this issue Feb 26, 2022
@janScheible
Data loss aften an orientation change. ruleant#195
3ad5188 
- addressing the child comments of ruleant#197 (review)
-- `StateTrackingDialogBuilder#trackState(...)` now stores text of text views in the state if text was changed programmatically
janScheible added a commit to janScheible/forked-getback_gps that referenced this issue Feb 26, 2022
@janScheible
Data loss aften an orientation change. ruleant#195
a5534a1 
- also added name to copyright section for the dialog state tracking changes
ruleant pushed a commit that referenced this issue Mar 1, 2022
@janScheible
Data loss aften an orientation change. #195 (#197)
66b2874 
* Data loss aften an orientation change. #195
- store view state in bundle

* Data loss aften an orientation change. #195
- fix of 'Document empty method body' from https://app.codacy.com/gh/ruleant/getback_gps/pullRequest?prid=8792030
- covered one more corner case: dialog was opened and device was rotated without started typing --> will still re-open the dialog after a config change

* Data loss aften an orientation change. #195
- introduced a constant for the bundle key

* Data loss aften an orientation change. #195
- extracted the state tracking to a custom dialog builder class (StateTrackingDialogBuilder), works now for all 3 dialogs

* Data loss aften an orientation change. #195
- fixes for https://app.codacy.com/gh/ruleant/getback_gps/pullRequest?prid=8792030

* Data loss aften an orientation change. #195
- fixes for https://app.codacy.com/gh/ruleant/getback_gps/pullRequest?prid=8792030

* Data loss aften an orientation change. #195

- addressing the child comments of #197 (review)
-- `StateTrackingDialogBuilder#trackState(...)` now stores text of text views in the state if text was changed programmatically

* Data loss aften an orientation change. #195

- also added name to copyright section for the dialog state tracking changes
@ruleant
Copy link
Owner

ruleant commented Mar 1, 2022

@ruleant ruleant linked a pull request Mar 17, 2022 that will close this issue
Data loss aften an orientation change. #195 #197
Merged
@davirec davirec mentioned this issue Mar 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruleant ruleant

Labels
bug priority medium
Projects
None yet
Milestone
v0.9
2 participants
@ruleant @aalmds