Add support for passing data attr to Python library rules, closes #257

rules-proto-grpc · Jun 4, 2023 · f17c845 · f17c845
1 parent 8c6b08f
commit f17c845
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/python/python_grpc_library.bzl b/python/python_grpc_library.bzl
@@ -22,6 +22,7 @@ def python_grpc_library(name, **kwargs):
         name = name,
         srcs = [name_pb],
         deps = GRPC_DEPS + kwargs.get("deps", []),
+        data = kwargs.get("data", []),  # See https://github.com/rules-proto-grpc/rules_proto_grpc/issues/257 for use case
         imports = [name_pb],
         **{
             k: v

diff --git a/python/python_grpclib_library.bzl b/python/python_grpclib_library.bzl
@@ -24,6 +24,7 @@ def python_grpclib_library(name, **kwargs):
         deps = [
             "@com_google_protobuf//:protobuf_python",
         ] + GRPC_DEPS + kwargs.get("deps", []),
+        data = kwargs.get("data", []),  # See https://github.com/rules-proto-grpc/rules_proto_grpc/issues/257 for use case
         imports = [name_pb],
         **{
             k: v

diff --git a/python/python_proto_library.bzl b/python/python_proto_library.bzl
@@ -22,6 +22,7 @@ def python_proto_library(name, **kwargs):
         name = name,
         srcs = [name_pb],
         deps = PROTO_DEPS + kwargs.get("deps", []),
+        data = kwargs.get("data", []),  # See https://github.com/rules-proto-grpc/rules_proto_grpc/issues/257 for use case
         imports = [name_pb],
         **{
             k: v

diff --git a/tools/rulegen/python.go b/tools/rulegen/python.go
@@ -53,6 +53,7 @@ def {{ .Rule.Name }}(name, **kwargs):
         name = name,
         srcs = [name_pb],
         deps = PROTO_DEPS + kwargs.get("deps", []),
+        data = kwargs.get("data", []),  # See https://github.com/rules-proto-grpc/rules_proto_grpc/issues/257 for use case
         imports = [name_pb],
         {{ .Common.LibraryArgsForwardingSnippet }}
     )
@@ -78,6 +79,7 @@ def {{ .Rule.Name }}(name, **kwargs):
         name = name,
         srcs = [name_pb],
         deps = GRPC_DEPS + kwargs.get("deps", []),
+        data = kwargs.get("data", []),  # See https://github.com/rules-proto-grpc/rules_proto_grpc/issues/257 for use case
         imports = [name_pb],
         {{ .Common.LibraryArgsForwardingSnippet }}
     )
@@ -106,6 +108,7 @@ def {{ .Rule.Name }}(name, **kwargs):
         deps = [
             "@com_google_protobuf//:protobuf_python",
         ] + GRPC_DEPS + kwargs.get("deps", []),
+        data = kwargs.get("data", []),  # See https://github.com/rules-proto-grpc/rules_proto_grpc/issues/257 for use case
         imports = [name_pb],
         {{ .Common.LibraryArgsForwardingSnippet }}
     )