Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set visibility of Swift protobuf #111

Closed
aaliddell opened this issue Feb 14, 2021 · 1 comment · Fixed by #106
Closed

Add option to set visibility of Swift protobuf #111

aaliddell opened this issue Feb 14, 2021 · 1 comment · Fixed by #106
Labels
enhancement New feature or request lang-swift Swift rules specific resolved-next-release Code to resolve issue is pending release

Comments

@aaliddell
Copy link
Member

See #97
@aaliddell aaliddell added enhancement New feature or request resolved-next-release Code to resolve issue is pending release labels Feb 14, 2021
@aaliddell aaliddell mentioned this issue Feb 14, 2021
Merged
aaliddell added a commit that referenced this issue Feb 14, 2021
@aaliddell
Mark generated swift files as public Visibility, closes #111
8603c03
aaliddell added a commit that referenced this issue Feb 14, 2021
@aaliddell
Revert "Mark generated swift files as public Visibility, closes #111"
9c0dedd 
This reverts commit 8603c03.
@aaliddell
Copy link
Member Author

Now available to be set with 'options' attr, rather then by setting public by default

@aaliddell aaliddell added the lang-swift Swift rules specific label Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request lang-swift Swift rules specific resolved-next-release Code to resolve issue is pending release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3.0.0 release rules-proto-grpc/rules_proto_grpc
1 participant
@aaliddell