Remove grpc sources from runfiles trees #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a C++ binary uses grpc code generated with cpp_grpc_library, the resulting runfiles tree includes the generated grpc sources. Reproducer here: https://gist.github.com/william-smith-skydio/e3b630f7cc826ad33f283b8017a88cc7 ```bash > tree bazel-bin/test.runfiles/__main__/ bazel-bin/test.runfiles/__main__/ ├── grpc_test_proto_cpp_pb │ ├── grpc_test.grpc.pb.cc -> ... │ ├── grpc_test.grpc.pb.h -> ... │ ├── grpc_test_mock.grpc.pb.h -> ... │ ├── grpc_test.pb.cc -> ... │ └── grpc_test.pb.h -> ... └── test -> ... ``` With this patch applied, I get the expected behavior: ```bash tree bazel-bin/test.runfiles bazel-bin/test.runfiles ├── __main__ │ └── test -> ... └── MANIFEST ``` This issue does not affect cpp_proto_library since that was already using the split srcs/hdrs targets.
|
Thanks |
aaliddell
added a commit
that referenced
this pull request
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a C++ binary uses grpc code generated with cpp_grpc_library, the resulting runfiles tree includes the generated grpc sources.
Reproducer here:
https://gist.github.com/william-smith-skydio/e3b630f7cc826ad33f283b8017a88cc7
With this patch applied, I get the expected behavior:
This issue does not affect cpp_proto_library since that was already using the split srcs/hdrs targets.