Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dedicated RoomName type #159

Closed
jplatte opened this issue Jul 25, 2020 · 5 comments · Fixed by #645
Closed

Add a dedicated RoomName type #159

jplatte opened this issue Jul 25, 2020 · 5 comments · Fixed by #645
Labels
area/events effort/medium help wanted

Comments

@jplatte
Copy link
Member

jplatte commented Jul 25, 2020

… to ruma_events::room::name. It should encapsulate the "max 255 characters" rule, implement TryFrom<String> and Into<String>.
@Frinksy Frinksy mentioned this issue Jun 24, 2021
Merged
@timokoesters
Copy link
Member

The PublicRoomsChunk struct in ruma-common/src/directory.rs also needs to be changed

@timokoesters
Copy link
Member

And RoomName should allow .to_string() or .as_str()

@jplatte
Copy link
Member Author

jplatte commented Jul 15, 2021 •
edited

Yes, definitely should wrap String / str / Box<str> and provide an as_str() / impl AsRef<str>; to_string() too via impl Display.

@Frinksy
Copy link
Contributor

Frinksy commented Jul 18, 2021

Since ruma-common does not depend on ruma-events, would it make sense to move the new RoomName type to ruma-identifiers?

@jplatte
Copy link
Member Author

jplatte commented Jul 19, 2021

Yes, sounds good 👍

@Frinksy Frinksy mentioned this issue Jul 19, 2021
Merged
@jplatte jplatte closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/events effort/medium help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RoomName struct to ruma_events::room::name. Frinksy/ruma
3 participants
@jplatte @Frinksy @timokoesters