New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RoomName struct to ruma_events::room::name. #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was definitely expected to be a breaking change. I'll update the base branch accordingly. In the future, please select the base branch to be next
for breaking changes (it might also be beneficial to use that as the starting point of your branch).
Re. empty RoomName
, I think that should be disallowed. The serde attribute on the field will prevent that from being a deserialization error in that context, but being able to have an empty RoomName
instance seems not useful.
I've updated the target branch and rebased my branch onto Also, I've added an |
It also makes it really awkward to use |
Thanks! |
Resolves: #159
I'm not sure if I'm going in the right direction for this PR. I've changed the constructor's signature for
NameEventContent
which would be a breaking change.Also, I'm not sure if creating a
RoomName
type should fail if the name is an emptyString
.There is one test which fails, but that is due to the fact that currently it's possible to create an empty
RoomName
.