Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: Add unstable support for reference relations #1119

Closed
wants to merge 1 commit into from

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented May 17, 2022

According to MSC3267

Working towards #1031

@zecakeh zecakeh mentioned this pull request May 17, 2022
@zecakeh zecakeh requested a review from a team May 17, 2022 11:45
@jplatte
Copy link
Member

jplatte commented May 17, 2022

Hm, that MSC is currently in draft status and mentions threads as a motivation, which seem to have been implemented differently in the meantime. Are you sure it's useful to have the MSC in Ruma in its current state?

@zecakeh
Copy link
Contributor Author

zecakeh commented May 17, 2022

Yes, it's needed for polls

@jplatte
Copy link
Member

jplatte commented May 17, 2022

I'm not convinced it should be its own feature flag, given it has literally no semantics on its own. I've commented on the MSC, let's see what others think.

@zecakeh
Copy link
Contributor Author

zecakeh commented May 17, 2022

The reason I put a feature flag is that there might be another unstable MSC that uses it before polls are made stable. I don't mind not making it separate.

As a side note, in-room key verification events seem to use it too, although it's not defined as being the same type.

@zecakeh
Copy link
Contributor Author

zecakeh commented May 23, 2022

I'm closing this as the MSC has been updated to reflect that this type has no meaning on its own, so it cannot be applied on any message event, as opposed to the other relations.

It would still be nice to move relations as suggested in #1121, that way we could use the same Reference type that's currently in room::encrypted for polls.

@zecakeh zecakeh closed this May 23, 2022
@jplatte jplatte deleted the zecakeh/reference branch May 23, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants