Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for read receipts for threads #1323

Merged
merged 2 commits into from Oct 10, 2022
Merged

Add support for read receipts for threads #1323

merged 2 commits into from Oct 10, 2022

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Oct 2, 2022 •
edited by github-actions bot

@zecakeh zecakeh requested a review from a team October 2, 2022 10:11
ShadowJonathan
ShadowJonathan approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@ShadowJonathan ShadowJonathan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to see the idea behind ReceiptThread::Unthreaded before i realised why this might be idiomatic behaviour, but it is.

I still want a second opinion, though.

@ShadowJonathan ShadowJonathan requested a review from a team October 2, 2022 11:08
jplatte
jplatte reviewed Oct 10, 2022
View reviewed changes
crates/ruma-common/src/events/receipt.rs Outdated Show resolved Hide resolved
crates/ruma-common/src/events/receipt.rs Outdated Show resolved Hide resolved
crates/ruma-common/src/events/receipt.rs Outdated Show resolved Hide resolved
crates/ruma-common/src/events/receipt/receipt_thread_serde.rs Outdated Show resolved Hide resolved
@zecakeh
Copy link
Contributor Author

zecakeh commented Oct 10, 2022

The force push was to rebase on main

@zecakeh zecakeh enabled auto-merge (rebase) October 10, 2022 18:44
@zecakeh zecakeh merged commit f9958ae into main Oct 10, 2022
@zecakeh zecakeh deleted the zecakeh/read-thread branch October 10, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte left review comments

@ShadowJonathan ShadowJonathan ShadowJonathan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MSC3771: Read receipts for threads
3 participants
@zecakeh @jplatte @ShadowJonathan