Improvements to the push module
#1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also planning to change the client-api's |
This was referenced Nov 3, 2022
|
The change in the client-api probably makes more sense to be done before the latest commit. As it's the request's rule type that we want to insert in a |
|
Since there's a lot of commits, this PR can be easily reviewed commit-by-commit. |
richvdh
pushed a commit
to matrix-org/matrix-spec
that referenced
this pull request
Nov 8, 2022
This is based on the behavior of Synapse and Dendrite. Conduit's implementation is already non-compliant in regards to what was already defined in the spec. Closes #645. Related to #647 (probably closes it too, unless we want to be more explicit somewhere about what can be changed on default push rules). Related PR in ruma that would allow to fix Conduit's implementation: ruma/ruma#1364 Signed-off-by: Kévin Commaille zecakeh@tedomum.fr
In practice, rule insertion is more complex than adding rules at the end of the ruleset. It can be easily replaced by using the methods of IndexSet.
|
Rebased to solve conflicts. The spec PRs have been merged so it should be fully ready for review. |
jplatte
reviewed
Nov 9, 2022
jplatte
approved these changes
Nov 9, 2022
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
…rix-org#1319) This is based on the behavior of Synapse and Dendrite. Conduit's implementation is already non-compliant in regards to what was already defined in the spec. Closes matrix-org#645. Related to matrix-org#647 (probably closes it too, unless we want to be more explicit somewhere about what can be changed on default push rules). Related PR in ruma that would allow to fix Conduit's implementation: ruma/ruma#1364 Signed-off-by: Kévin Commaille zecakeh@tedomum.fr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See these spec PRs for the last commit's logic: matrix-org/matrix-spec#1319, matrix-org/matrix-spec#1320.
Closes #466.
Closes #467.
Preview Removed