Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate state-res #558

Merged
merged 140 commits into from May 7, 2021
Merged

Integrate state-res #558

merged 140 commits into from May 7, 2021

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented May 7, 2021

Opening a PR to have CI run.

@DevinR528
Initial commit sketching out ideas
61f485e
@DevinR528
Sketch is mostly finalized now fill in with code
c043b10
@DevinR528
Use ruma's PDU events not the sent events
d3c3c95
@DevinR528
Update readme for repo
b2cbc3c
@DevinR528
Done transcribing all logic is filled in no more unimplemented!
954fe5e
@DevinR528
Reviewed to reverse_topo_power_sort
40248ef
@DevinR528
Fixing failing first failing state res test
0c21f38 
lexicographical_topological_sort test passes. Chasing bug somewhere in
resolve.
@DevinR528
Working at get_auth_chain_diff
d69e712
@DevinR528
BUG: follows synapse until get_mainline_depth then it loops forever
2f443cf
@DevinR528
Working ban_vs_power_level test, add travis.yml, logging
5842ddf
@DevinR528
Room topic reset test fails
a0db51b
@DevinR528
lexi_topo_sort needs to return a neg power_level to sort properly
106cab4 
All tests pass!!! Changed println! to logger calls.
@DevinR528
Fix separate ignoring missing ids and auth_check details
29d86eb
@DevinR528
Add benchmarks for lexi_topo and state resolve method
0ae8c8f
@DevinR528
Update readme to more accuratly reflect API
ea0b6ad
@DevinR528
Add benchmark for longer auth chain and Error type
d8fb5ca 
This required that the code being run in the benchmark be tested to
verify it works correctly. Now work can begin cleaning up and optimizing
state-res.
@DevinR528
Move all event access to _get_event method
4990dac 
We now use the event_map when possible, only accessing the state store
when event_map fails. A -4.8578% increase in perf was observed.
@DevinR528
Clean up logging calls
77cbcc7
@DevinR528
House keeping, remove &mut self in all methods
8a9f15e 
Improved perf -7.8220%
@DevinR528
StateResolution's methods take &self now + more clean up
1850479
@DevinR528
Bump ruma to same rev as conduit federation-p2p branch
9a388fc
@DevinR528
Update ruma depricated and use Option<String> for state_key
1509ef4
@DevinR528
Update how PDU works this needs to be fixed TODO
5a45970 
I have just added a hack to make the Pdu deserialize correctly in the
tests this has to be fixed!!
@DevinR528
Update ruma with conduit, make event_id return EventId not Option<>
5f77bc1
@DevinR528
Export all of the event_auth mod
484f48d
@DevinR528
Continue to update to keep compatibility with conduit
6e0edce
@DevinR528
Make auth_types_for_event take the ruma types instead of StateEvent
d22d835
@DevinR528
Add docs and rename _get_event -> get_or_load_event
ccc7531
@DevinR528
Update signatures since Cargo.lock seemed to be using cached ruma
85693cc
@DevinR528
Update ruma to latest
789c814
timokoesters and others added 28 commits April 22, 2021 18:50
@timokoesters @jplatte
Bump ruma
aa53d07
@jplatte
Bump ruma dependency
1dd252d
@DevinR528
Clean up unused bits add TODOs
8103bbc
@DevinR528
Replace threads -> tasks in TODO comments
a9e248d
@DevinR528
Remove StateResolution::apply_event, fix test serde make pdu struct
c2988d4
@jplatte
Clean up state_res_bench.rs
a7205c6
@jplatte
Bump ruma
ce665d2
@jplatte
ci: Replace travis with GitHub actions
d235957
@jplatte
Make README title bigger
72930a6
@jplatte
Title-case the README title
3bffb8a
@DevinR528
Create architecture document
ca01f33
@DevinR528
Add linebreaks at < 90, fix awkward phrasings
d533c96
@DevinR528
Add more info to lib and state_event sections, fix english bugs
29fd085
@DevinR528
Remove room_version section
d359367
@jplatte
Bump ruma
c20893e
@DevinR528
Use the RoomVersion struct in event_auth
138ecd4
@DevinR528
Remove StateStore trait and clean up imports in event_auth
f62df4d
@DevinR528
Remove state_store module
41b8c14
@DevinR528
Remove so many allocations for auth chain, address review
509283d
@jplatte
Fix default-allowed clippy lints
56bf45c
@jplatte
Add 'crates/ruma-state-res/' from commit '56bf45c0235701ac6df56993c32…
6609829 
…7d2f97a499ef9'

git-subtree-dir: crates/ruma-state-res
git-subtree-mainline: 719433e
git-subtree-split: 56bf45c
@jplatte
Integrate state-res and rename to ruma-state-res
addc670
@jplatte
events: Add missing dependency feature
ee39f7c
@jplatte
state-res: Depend on ruma-* subcrates instead of ruma
f58462a
@jplatte
state-res: Upgrade rand and update usage
410b4ae
@jplatte
state-res: Switch from log to tracing
9263d0c
@jplatte
ruma: Including client in full feature
74562f2
@jplatte
ruma: Re-export state-res
10fd467
@jplatte jplatte merged commit 10fd467 into main May 7, 2021
@jplatte jplatte deleted the state-res branch May 7, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jplatte @DevinR528 @q-b @timokoesters