identity-service-api: Add 3PID validity endpoint. #618
Conversation
| } | ||
|
|
||
| request: { | ||
| /// The Session ID enerated by the `requestToken` call. |
There was a problem hiding this comment.
Typo, "generated" is missing the first letter.
There was a problem hiding this comment.
Also requestToken should probably be the module name we use for that endpoint, and be an intra-doc link like [request_token](crate::whatever::request_token::v2). Same below.
There was a problem hiding this comment.
I'm not sure how to best do the intra-doc link, since it seems that there are 2 possible modules for requestToken calls:
- ruma::api::identity_service::association::email::create_email_validation_session
- ruma_identity_service_api::association::msisdn::create_msisdn_validation_session
Would it be a good idea to link to both? In other parts of the codebase, I saw it just being mentioned as a requestToken call, which is why I did it in the first place.
There was a problem hiding this comment.
Oh, I see. We can keep it as-is then (and possibly revisit later).
crates/ruma-identity-service-api/src/association/check_3pid_validity/v2.rs
Outdated
Show resolved
Hide resolved
iinuwa
left a comment
iinuwa
left a comment
There was a problem hiding this comment.
Thanks! This looks pretty close. Added a couple of notes on top of jplatte's.
crates/ruma-identity-service-api/src/association/check_3pid_validity/v2.rs
Outdated
Show resolved
Hide resolved
crates/ruma-identity-service-api/src/association/check_3pid_validity/v2.rs
Outdated
Show resolved
Hide resolved
crates/ruma-identity-service-api/src/association/check_3pid_validity/v2.rs
Outdated
Show resolved
Hide resolved
Capitalize 3PID. Use borrowed types. Use Medium type.
|
Thanks! |
4 participants
Resolves: #329