Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity-service-api: Add 3PID validity endpoint. #618

Merged
merged 2 commits into from Jun 8, 2021

Conversation

Frinksy
Copy link
Contributor

@Frinksy Frinksy commented Jun 7, 2021

Resolves: #329

@Frinksy Frinksy requested a review from iinuwa as a code owner June 7, 2021 14:37
}

request: {
/// The Session ID enerated by the `requestToken` call.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, "generated" is missing the first letter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also requestToken should probably be the module name we use for that endpoint, and be an intra-doc link like [request_token](crate::whatever::request_token::v2). Same below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to best do the intra-doc link, since it seems that there are 2 possible modules for requestToken calls:

Would it be a good idea to link to both? In other parts of the codebase, I saw it just being mentioned as a requestToken call, which is why I did it in the first place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. We can keep it as-is then (and possibly revisit later).

Copy link
Member

@iinuwa iinuwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks pretty close. Added a couple of notes on top of jplatte's.

Capitalize 3PID.
Use borrowed types.
Use Medium type.
@iinuwa iinuwa merged commit 76118b0 into ruma:main Jun 8, 2021
@iinuwa
Copy link
Member

iinuwa commented Jun 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

identity-service: Add 3PID validity check endpoint
4 participants