identity-service-api: Add 3PID validity endpoint. #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jun 7, 2021
| } | ||
|
|
||
| request: { | ||
| /// The Session ID enerated by the `requestToken` call. |
There was a problem hiding this comment.
Typo, "generated" is missing the first letter.
There was a problem hiding this comment.
Also requestToken should probably be the module name we use for that endpoint, and be an intra-doc link like [request_token](crate::whatever::request_token::v2). Same below.
There was a problem hiding this comment.
I'm not sure how to best do the intra-doc link, since it seems that there are 2 possible modules for requestToken calls:
- ruma::api::identity_service::association::email::create_email_validation_session
- ruma_identity_service_api::association::msisdn::create_msisdn_validation_session
Would it be a good idea to link to both? In other parts of the codebase, I saw it just being mentioned as a requestToken call, which is why I did it in the first place.
There was a problem hiding this comment.
Oh, I see. We can keep it as-is then (and possibly revisit later).
crates/ruma-identity-service-api/src/association/check_3pid_validity/v2.rs
Outdated
Show resolved
Hide resolved
iinuwa
requested changes
Jun 7, 2021
crates/ruma-identity-service-api/src/association/check_3pid_validity/v2.rs
Outdated
Show resolved
Hide resolved
crates/ruma-identity-service-api/src/association/check_3pid_validity/v2.rs
Outdated
Show resolved
Hide resolved
DevinR528
reviewed
Jun 7, 2021
crates/ruma-identity-service-api/src/association/check_3pid_validity/v2.rs
Outdated
Show resolved
Hide resolved
Capitalize 3PID. Use borrowed types. Use Medium type.
jplatte
approved these changes
Jun 7, 2021
iinuwa
approved these changes
Jun 8, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #329