Event changes for room versions 7, 8, and 9 #771
Conversation
| #[cfg_attr(docsrs, doc(cfg(feature = "unstable-pre-spec")))] | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| #[ruma_event(skip_redaction)] | ||
| pub join_authorised_via_users_server: Option<UserId>, |
There was a problem hiding this comment.
Oh no, did the spec introduce a British English name once again? If this is really what the spec says, can you add a serde(rename) but use authorized (with z) for the field name, for consistency within Ruma?
There was a problem hiding this comment.
I remember reading that British English is part of the Matrix spec style guide, but I can't seem to find the reference now.
Edit: found it. https://github.com/matrix-org/matrix-doc/blob/main/meta/documentation_style.rst#general
There was a problem hiding this comment.
There's 25 matches for authoriz (and 11 for authoris) on https://spec.matrix.org/v1.1/client-server-api/, so if there is the policy at all, they are not very good at enforcing it 😅
| // FIXME: Any entries in the list which do not match the expected format are ignored. Thus, if all | ||
| // entries are invalid, the list behaves as if empty and all users without an invite are rejected. | ||
| // i.e. ser/de needs to be lax |
There was a problem hiding this comment.
What is this fixme about? How could entries in the list be honored if they don't follow the expected format?
There was a problem hiding this comment.
I think it's more that you can't throw away the event (the join rule event) as invalid but turn it into a restricted join rule event with no entries?
https://github.com/matrix-org/matrix-doc/blob/main/proposals/3083-restricted-rooms.md#proposal Third actual "paragraph" or first one after bullet points.
There was a problem hiding this comment.
I'm not sure that's what that paragraph says. Either way our deserialization is already "lax" because we have AllowRule::_Custom, no?
There was a problem hiding this comment.
Oh are they more talking about the shape of the JSON, like it has to look like
{
"type": "m.some_supported_type",
"room_id": "!realroomid"
}or something they come up with in the future and not that the individual pieces could be invalid.
Well either way I got rid of the FIXME.
DevinR528
force-pushed
the
event-roomver
branch
from
a15364a
to
74de3da
Compare
DevinR528
force-pushed
the
event-roomver
branch
from
74de3da
to
eb435cf
Compare
DevinR528
force-pushed
the
event-roomver
branch
from
eb435cf
to
9b938c3
Compare
Partial fix for #718
Taken from #738