Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for Android 10 HU #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

AirOne70
Copy link

Make the app working again on Android 10.
My car is not a VW/Skoda so I have not been able to fully test the app.

@rumburake
Copy link
Owner

Thank you for updating! I have a few comments:

  • I have only Android 9 (Hal 9k) - Adroid 10 will not work for me because of incompatible Bluetooth. If we change the code, it will no wok on lower versions?
  • What car did you test this on?
  • The test and config activities seem to have been removed, how will we access the UI?

@AirOne70
Copy link
Author

Thanks for taking a look at my request!

  • I don't have an Android 9 HU so I can't guarantee that it is perfectly fine, but it should be. You can still build the app before merging, and check if everything works. https://github.com/AirOne70/AutoVolume
  • I tested this on my PX5 HU, using my Citroën DS3 (not able to read speed / rpm / from CanBus)
  • Nothing has been removed from the app, I only removed some commented out code from the manifest. So it's working the same way as before. 😀

@FogfiRED
Copy link

Is there a compiled apk that i could test an a PX6 Andorid 10 HU?

@AirOne70
Copy link
Author

Is there a compiled apk that i could test an a PX6 Andorid 10 HU?

You may try this one :
AutoVolume-Android10.zip

@fiffi-1954
Copy link

Hi AirOne70! Your "AutoVolume-Android10" works very god. The radio did not accept any other AutoVolume. Thanks

@HG-Blob
Copy link

HG-Blob commented Feb 23, 2023

Hi AirOne70. I installed the version you posted on Mar 27, 2021 on my "MIC AV8V7-LITE" radio mounted in a VW Polo 6R. Unfortunately I faced the bug of high volume when the engine stops which should be solved in version 1.2.1.
Do you have any idea how to fix this?
Thanks a lot in advance!

@AirOne70
Copy link
Author

Hi HG-Bob, sorry but I have no idea.
Are you able to see engine rpms and vehicule speed values in real time within the app when you're turning your engine off?

@HG-Blob
Copy link

HG-Blob commented Feb 23, 2023

Thanks for the answer. Yes, I can see the live data. After turning off the engine, speed value jumps up from zero to something over 300 km/h. It looks pretty much like here: #2

@AirOne70
Copy link
Author

Oh ok, and what about engine revs?
Like rumburake said, the fix was to force speed to 0 when rev is 0.

@HG-Blob
Copy link

HG-Blob commented Feb 23, 2023

Good hint, thanks. At least this leads to a work around.
When I stop the engine, rev stays at idle (~980rpm). So the fix doesn't work. When I turn the key back to ignition without starting the engine, it goes down to 0rpm and Volume jumps back.

@HG-Blob
Copy link

HG-Blob commented Feb 23, 2023

Maybe another fix would be to ignore 327km/h because it is exactly the same speed as in the other issue.
...And I guess no car which really drives 327km/h has a 3rd party Android radio. ;D

Some cars are sending a speed of 327km/h when stopped.
@AirOne70
Copy link
Author

Here is a new build to test (I'm not able to test it myself). I hope that it will work for you!
AutoVolume-Android10-327fix.zip

@HG-Blob
Copy link

HG-Blob commented Feb 24, 2023

Thanks a lot for the new version. I tried it but unfortunately the issue is not solved.
It seems that the 327km/h do not come from CAN bus but somehow due to interrupted communication. In the attached video you can see that the rev is frozen when stopping the engine. So I guess the communication with CAN bus stops. The increase of speed is round about 6 seconds delayed while the rev still stays frozen.
With turning ignition on in the end, both values go down to 0 when communication with CAN bus is restored.
https://user-images.githubusercontent.com/91486556/221168873-0f00fc57-1151-4b5a-841a-d25db9077014.mp4

@AirOne70
Copy link
Author

Thanks a lot for your feedback.
I think that 327.00 is not the exact value sent by your car, that's why the check is failing.
It would probably be safer to check if it's higher than 320 for example.
Will do it later today. ;)

@AirOne70
Copy link
Author

Here is a new one, which should set speed to 0 if rev < 3000 and speed > 320.
AutoVolume-Android10-320+fix.zip

@HG-Blob
Copy link

HG-Blob commented Feb 25, 2023

I have just tested the new version with v>320km/h and it works. The speed stays at 0km/h after stopping the engine. Thank you very very much, AirOne70! 😀

@AirOne70
Copy link
Author

Nice to hear that!
Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants