Push progress #16
Merged
Push progress #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
force-pushed
the
containerd-push-progress
branch
3 times, most recently
from
71b8c20
to
5f268e3
Compare
|
Can be rebased :) |
vvoland
force-pushed
the
containerd-push-progress
branch
from
5f268e3
to
718770f
Compare
rumpl
reviewed
Jul 18, 2022
daemon/containerd/progress.go
Outdated
| func showProgress(ctx context.Context, ongoing *jobs, cs content.Store, w io.Writer, stop chan struct{}) { | ||
| type updateProgressFunc func(ctx context.Context, ongoing *jobs, output progress.Output, start time.Time) error | ||
|
|
||
| func ShowProgress(ctx context.Context, ongoing *jobs, w io.Writer, updateFunc updateProgressFunc) func() { |
There was a problem hiding this comment.
This doesn't have to be an exported function, can be showProgress
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
containerd-push-progress
branch
from
718770f
to
bae9267
Compare
rumpl
approved these changes
Jul 19, 2022
This was referenced Sep 1, 2022
|
When upstreaming:
combine with one or more of; |
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to:
Add progress for push. This shares code with pull progress and I extracted common things to other file to avoid cluttering service.go.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)