Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field regex and date regex fix #43

Merged
merged 2 commits into from Dec 3, 2019

Conversation

saludangelito
Copy link
Contributor

  • removed gi from date format regex
  • added no space checker for field regex
  • updated unit test for campaign member field validation

Copy link
Contributor

@iamEAP iamEAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -41,6 +41,8 @@ export class CampaignMemberFieldEquals extends BaseStep implements StepInterface
const expectedValue: string = stepData.expectedValue;
let campaignMember: Record<string, any>;

console.log(operator);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Stray console log.

@iamEAP iamEAP merged commit b521fc2 into run-crank:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants