Skip to content

Commit

Permalink
convert folder to a module
Browse files Browse the repository at this point in the history
  • Loading branch information
jlewitt1 committed Jul 15, 2024
1 parent ed91cd6 commit 302236b
Show file tree
Hide file tree
Showing 19 changed files with 302 additions and 208 deletions.
2 changes: 1 addition & 1 deletion runhouse/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from pathlib import Path
from typing import List

RESERVED_SYSTEM_NAMES: List[str] = ["file", "s3", "gs", "azure", "here", "ssh", "sftp"]
RESERVED_SYSTEM_NAMES: List[str] = ["file", "s3", "gs", "azure", "here"]
CLUSTER_CONFIG_PATH: str = "~/.rh/cluster_config.json"
CONFIG_YAML_PATH: str = "~/.rh/config.yaml"
SERVER_LOGFILE_PATH = "~/.rh/server.log"
Expand Down
2 changes: 1 addition & 1 deletion runhouse/resources/blobs/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def exists_in_system(self):
>>> file = rh.file(data, path="saved/path")
>>> file.exists_in_system()
"""
return self._folder.exists_in_system(self.fsspec_url)
return self._folder.exists_in_system()


def file(
Expand Down
3 changes: 2 additions & 1 deletion runhouse/resources/envs/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

from runhouse.logger import logger
from runhouse.resources.envs.utils import _process_env_vars, run_setup_command
from runhouse.resources.folders import Folder
from runhouse.resources.hardware import _get_cluster_from, Cluster
from runhouse.resources.packages import Package
from runhouse.resources.resource import Resource
Expand Down Expand Up @@ -107,6 +106,8 @@ def reqs(self, reqs):

def _reqs_to(self, system: Union[str, Cluster], path=None, mount=False):
"""Send self.reqs to the system (cluster or file system)"""
from runhouse.resources.folders import Folder

new_reqs = []
for req in self.reqs:
if isinstance(req, str):
Expand Down
Loading

0 comments on commit 302236b

Please sign in to comment.