-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install preferred version only if package is not already installed. #1058
base: main
Are you sure you want to change the base?
Install preferred version only if package is not already installed. #1058
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
def get_bs4_version(): | ||
import bs4 | ||
|
||
return plotly.__version__ | ||
return bs4.__version__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we gonna rotate this every time you change the instal logic pal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can you add it to test/requirements.txt, otherwise will break when people try to run this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, though not sure if we should land until after release?
f192d78
to
5953635
Compare
5953635
to
7ea23ec
Compare
No description provided.