Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install preferred version only if package is not already installed. #1058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Install preferred version only if package is not already installed. #1058

wants to merge 1 commit into from

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Jul 23, 2024

No description provided.

@rohinb2 Graphite App
Copy link
Contributor Author

rohinb2 commented Jul 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on Graphite Graphite

@rohinb2 rohinb2 mentioned this pull request Jul 23, 2024
Merged
dongreenberg
dongreenberg reviewed Jul 23, 2024
View reviewed changes
tests/test_resources/test_data/test_package.py
Comment on lines +11 to +14
def get_bs4_version():
import bs4

return plotly.__version__
return bs4.__version__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we gonna rotate this every time you change the instal logic pal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you add it to test/requirements.txt, otherwise will break when people try to run this test

dongreenberg
dongreenberg approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@dongreenberg dongreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, though not sure if we should land until after release?

Base automatically changed from 07-23-Remove_unused_Package_helper_functions to main July 23, 2024 21:38
@rohinb2 rohinb2 force-pushed the 07-23-Install_preferred_version_only_if_package_is_not_already_installed branch from f192d78 to 5953635 Compare July 23, 2024 21:38
@rohinb2 rohinb2 force-pushed the 07-23-Install_preferred_version_only_if_package_is_not_already_installed branch from 5953635 to 7ea23ec Compare August 8, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongreenberg dongreenberg dongreenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohinb2 @dongreenberg