Cluster default env #678

carolineechen · 2024-03-28T21:07:51Z

default env flow

passed in at cluster initialization
default env installations is set up on cluster using pure ssh commands
run the http server start inside the env, passing in default_env which is propagated to the cluster env set up
put the default env resource on the cluster, and set the env vars after

behavior

cluster.run, cluster.put, etc runs inside cluster.default_env if not explicitly specified
if no default env is provided, defaults to base_env

TODOs (can be in follow up?)

env vars support -- currently set w/ after runhouse start on the default env. can be instead appended to runhouse start command and as a result flow into all subprocesses (flow to add to start cmd kinda annoying tho)

carolineechen · 2024-03-28T21:08:05Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on Graphite

runhouse/resources/hardware/cluster.py

rohinb2 · 2024-04-22T18:22:45Z

runhouse/main.py

@@ -148,6 +148,9 @@ def _print_status(config):

    first_info_to_print = ["den_auth", "server_connection_type", "server_port"]

+    if config.get("default_env") and isinstance(config["default_env"], Dict):


this should probably be if config.get("default_env") is not None and ...

rohinb2 · 2024-04-22T18:25:55Z

runhouse/resources/envs/env.py

@@ -205,12 +206,10 @@ def to(
        new_env.secrets = self._secrets_to(system)

        if isinstance(system, Cluster):
+            if new_env.name == Env.DEFAULT_NAME:


Confused on this check

rohinb2 · 2024-04-22T18:30:31Z

runhouse/resources/hardware/cluster.py

+        if self.is_up():
+            self.check_server()
+            if not self.get(self._default_env.name):
+                self._sync_default_env_to_cluster()


instead of doing sync and then put resource, could I not just do .to

rohinb2 · 2024-04-22T20:46:15Z

Merge activity

Apr 22, 4:46 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
Apr 22, 4:58 PM EDT: Graphite rebased this pull request as part of a merge.
Apr 22, 4:59 PM EDT: @rohinb2 merged this pull request with Graphite.

carolineechen force-pushed the cc/cluster-init-env branch 3 times, most recently from b033875 to 615e2ed Compare March 29, 2024 03:05

carolineechen changed the base branch from main to cc/sky-utils-autostop April 2, 2024 20:58

carolineechen force-pushed the cc/cluster-init-env branch from 615e2ed to 700f66c Compare April 2, 2024 20:58

This was referenced Apr 2, 2024

Remove sky dependency for autostop configs #697

Merged

Util for running cmds on local/cluster #698

Merged

carolineechen force-pushed the cc/cluster-init-env branch from 700f66c to 3b6945c Compare April 2, 2024 21:19

carolineechen changed the base branch from cc/sky-utils-autostop to cc/cmd-util April 2, 2024 21:19

rohinb2 reviewed Apr 2, 2024

View reviewed changes

runhouse/resources/hardware/cluster.py Outdated Show resolved Hide resolved

carolineechen force-pushed the cc/cluster-init-env branch from 3b6945c to b950de1 Compare April 3, 2024 16:52

carolineechen force-pushed the cc/cmd-util branch 2 times, most recently from a7ed140 to ab4625f Compare April 4, 2024 01:25

carolineechen force-pushed the cc/cluster-init-env branch from b950de1 to da17024 Compare April 4, 2024 01:41

carolineechen force-pushed the cc/cmd-util branch 3 times, most recently from e204d8a to ec01315 Compare April 5, 2024 05:47

carolineechen mentioned this pull request Apr 5, 2024

Add basic package tests #710

Merged

carolineechen changed the base branch from cc/cmd-util to cc/pkg-tests April 5, 2024 05:49

carolineechen force-pushed the cc/cluster-init-env branch from da17024 to b014294 Compare April 5, 2024 05:49

carolineechen force-pushed the cc/pkg-tests branch 2 times, most recently from 726f4d8 to 8d164d2 Compare April 7, 2024 00:24

carolineechen force-pushed the cc/cluster-init-env branch from b014294 to a459ec9 Compare April 7, 2024 00:24

carolineechen force-pushed the cc/pkg-tests branch 2 times, most recently from 3f399c8 to 5e0124b Compare April 9, 2024 02:39

carolineechen force-pushed the cc/cluster-init-env branch from a459ec9 to 9180cf2 Compare April 9, 2024 02:39

carolineechen changed the base branch from cc/pkg-tests to cc/from-config-arg April 9, 2024 02:39

This was referenced Apr 9, 2024

Optional resolve children arg from from_name/config #714

Merged

Add tests for default env #715

Merged

carolineechen force-pushed the cc/from-config-arg branch from 569227b to 33860f2 Compare April 9, 2024 02:45

carolineechen force-pushed the cc/cluster-init-env branch from 9180cf2 to a808817 Compare April 9, 2024 03:49

carolineechen force-pushed the cc/from-config-arg branch from ac1c56f to 61759b6 Compare April 9, 2024 21:14

carolineechen force-pushed the cc/cluster-init-env branch 5 times, most recently from a8ad009 to 5508282 Compare April 10, 2024 20:33

carolineechen force-pushed the cc/from-config-arg branch from 61759b6 to a67e4cb Compare April 12, 2024 20:41

carolineechen force-pushed the cc/cluster-init-env branch from 5508282 to b5b5e3f Compare April 12, 2024 20:41

carolineechen marked this pull request as ready for review April 12, 2024 20:53

carolineechen force-pushed the cc/cluster-init-env branch 2 times, most recently from aed9159 to 4321a16 Compare April 15, 2024 05:07

dongreenberg force-pushed the cc/from-config-arg branch from a67e4cb to d569840 Compare April 19, 2024 05:18

dongreenberg force-pushed the cc/cluster-init-env branch from 4321a16 to 35c4575 Compare April 19, 2024 05:18

dongreenberg mentioned this pull request Apr 19, 2024

Install Runhouse on the Cluster before Default Env so user settings override Runhouse reqs #745

Closed

rohinb2 reviewed Apr 22, 2024

View reviewed changes

rohinb2 force-pushed the cc/from-config-arg branch from d569840 to 2710b3a Compare April 22, 2024 20:54

rohinb2 changed the base branch from cc/from-config-arg to main April 22, 2024 20:56

carolineechen added 2 commits April 22, 2024 20:57

add default env

e5394ce

runtime env, default env

cf98546

rohinb2 force-pushed the cc/cluster-init-env branch from 35c4575 to cf98546 Compare April 22, 2024 20:57

rohinb2 merged commit dde13ea into main Apr 22, 2024
11 checks passed

jlewitt1 deleted the cc/cluster-init-env branch April 24, 2024 21:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cluster default env #678

Cluster default env #678

carolineechen commented Mar 28, 2024 •

edited

Loading

carolineechen commented Mar 28, 2024 •

edited

Loading

rohinb2 Apr 22, 2024

rohinb2 Apr 22, 2024

rohinb2 Apr 22, 2024

rohinb2 commented Apr 22, 2024 •

edited

Loading

		@@ -148,6 +148,9 @@ def _print_status(config):

		first_info_to_print = ["den_auth", "server_connection_type", "server_port"]

		if config.get("default_env") and isinstance(config["default_env"], Dict):

Cluster default env #678

Cluster default env #678

Conversation

carolineechen commented Mar 28, 2024 • edited Loading

carolineechen commented Mar 28, 2024 • edited Loading

rohinb2 Apr 22, 2024

Choose a reason for hiding this comment

rohinb2 Apr 22, 2024

Choose a reason for hiding this comment

rohinb2 Apr 22, 2024

Choose a reason for hiding this comment

rohinb2 commented Apr 22, 2024 • edited Loading

Merge activity

carolineechen commented Mar 28, 2024 •

edited

Loading

carolineechen commented Mar 28, 2024 •

edited

Loading

rohinb2 commented Apr 22, 2024 •

edited

Loading