Proxy tunnel support, including subclassing SSHCommandRunner #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| max_retry: int = 1, | ||
| ) -> None: | ||
| # temp update rsync filters to exclude docs, when syncing over runhouse folder | ||
| org_rsync_filter = cr.RSYNC_FILTER_OPTION |
There was a problem hiding this comment.
this could also be pretty easily adapted to handle --delete option if we want to do that. it does get a little messy/confusing against other methods like fsspec folder copying though, where certain options will support these features and others may not
carolineechen
force-pushed
the
proxy_tunneling
branch
4 times, most recently
from
f884e93
to
609d25f
Compare
- Create a subclass of SSHCommandRunner for cleanliness and richer options. - Tweak working_dir behavior slightly more
carolineechen
force-pushed
the
proxy_tunneling
branch
from
609d25f
to
87edfc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending - allowing more ssh options, replace cluster.ssh with CommandRunner.