Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pointers to store absolute path and work with .to. #989

Merged

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Jul 10, 2024

Only change the module pointers to the remote_import_path when actually running .to.

In that case, we generate the remote_import_path relative to whatever env it is being .to into.

Copy link

sentry-io bot commented Jul 10, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/module.py

Function Unhandled Issue
to [**ValueError: Need an initialized local server in order to put a module onto rh.here. Please run runhouse re...**](https://runhouse.sentry.io/issues/5540885505/?referrer=github-open-pr-bot) ... <br> Event Count:` 1

Did you find this useful? React with a 👍 or 👎

@rohinb2 rohinb2 force-pushed the 07-10-Change_pointers_to_store_absolute_path_and_work_with_.to_ branch 3 times, most recently from 40f221b to c2c5d7f Compare July 10, 2024 22:50
@rohinb2 rohinb2 changed the base branch from 07-03-Test_sending_a_Module_directly_to_a_new_env to rohin/prepend-sys-path-always July 10, 2024 22:50
@rohinb2 rohinb2 force-pushed the 07-10-Change_pointers_to_store_absolute_path_and_work_with_.to_ branch 3 times, most recently from 2c44c86 to 7e3ac38 Compare July 11, 2024 18:56
@rohinb2 rohinb2 force-pushed the rohin/prepend-sys-path-always branch from d9ec5b4 to 2dde9db Compare July 12, 2024 17:48
@rohinb2 rohinb2 force-pushed the 07-10-Change_pointers_to_store_absolute_path_and_work_with_.to_ branch from 7e3ac38 to 41ab1af Compare July 12, 2024 17:48
Copy link
Contributor Author

rohinb2 commented Jul 12, 2024

Merge activity

  • Jul 12, 4:13 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Jul 12, 4:17 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 12, 4:18 PM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 force-pushed the rohin/prepend-sys-path-always branch from 2dde9db to 4ac7656 Compare July 12, 2024 20:14
Base automatically changed from rohin/prepend-sys-path-always to main July 12, 2024 20:16
@rohinb2 rohinb2 force-pushed the 07-10-Change_pointers_to_store_absolute_path_and_work_with_.to_ branch from 41ab1af to e5f30f2 Compare July 12, 2024 20:16
@rohinb2 rohinb2 merged commit 5fc11a2 into main Jul 12, 2024
12 of 13 checks passed
@rohinb2 rohinb2 deleted the 07-10-Change_pointers_to_store_absolute_path_and_work_with_.to_ branch July 12, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant