-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change pointers
to store absolute path and work with .to
.
#989
Merged
rohinb2
merged 1 commit into
main
from
07-10-Change_pointers_to_store_absolute_path_and_work_with_.to_
Jul 12, 2024
Merged
Change pointers
to store absolute path and work with .to
.
#989
rohinb2
merged 1 commit into
main
from
07-10-Change_pointers_to_store_absolute_path_and_work_with_.to_
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/resources/module.py
Did you find this useful? React with a 👍 or 👎 |
This was referenced Jul 10, 2024
40f221b
to
c2c5d7f
Compare
This was referenced Jul 10, 2024
2c44c86
to
7e3ac38
Compare
This was referenced Jul 12, 2024
d9ec5b4
to
2dde9db
Compare
7e3ac38
to
41ab1af
Compare
2dde9db
to
4ac7656
Compare
41ab1af
to
e5f30f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only change the module pointers to the
remote_import_path
when actually running.to
.In that case, we generate the
remote_import_path
relative to whatever env it is being.to
into.