Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add multi modal RAG #280

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Feat: Add multi modal RAG #280

merged 5 commits into from
Dec 18, 2023

Conversation

marcusschiesser
Copy link
Collaborator

@marcusschiesser marcusschiesser commented Dec 15, 2023

No description provided.

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 10:21am

Copy link
Contributor

sweep-ai bot commented Dec 15, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Comment on lines +111 to +124
// XXX: Hack, if it's an image node, we reconstruct the image from the URL
// Alternative: Store image in doc store and retrieve it here
if (node instanceof ImageNode) {
node.image = node.getUrl();
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see ms/store-images-in-docstore

@marcusschiesser marcusschiesser merged commit e9f6de1 into main Dec 18, 2023
6 of 7 checks passed
@marcusschiesser marcusschiesser deleted the ms/add-multi-modal-rag branch December 18, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant