feat: add base evaluator and correctness evaluator #559
Conversation
🦋 Changeset detectedLatest commit: abf3482 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1,42 @@ | |||
| import { | |||
There was a problem hiding this comment.
How about adding
- README for the new
evaluationfolder - docs for using
CorrectnessEvaluator
?
There was a problem hiding this comment.
@marcusschiesser I'd have it on the pipeline
| evaluateResponse( | ||
| query: string, | ||
| response: Response, | ||
| ): Promise<EvaluationResult>; |
There was a problem hiding this comment.
looks to me like this is not needed (if evaluate would use a parameter object)
There was a problem hiding this comment.
@marcusschiesser was missing a few lines of code that make the DX better with evaluateResponse
There was a problem hiding this comment.
wondering about change BaseEvaluator to a class then we can have this evaluateResponse on the base class
|
My recent commit might affect your code. Please add .js extensions for each import. And read https://www.typescriptlang.org/docs/handbook/modules/reference.html#node16-nodenext-1 to know what's the reason. If you have any question please ping me |
No description provided.