feat: truncate embedding tokens #918
Merged
+231
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marcusschiesser
commented
Jun 10, 2024
•
marcusschiesser
commented
- truncate text to embed before sending it to OpenAI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a3694dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
himself65
reviewed
Jun 10, 2024
| @@ -109,6 +123,16 @@ export class OpenAIEmbedding extends BaseEmbedding { | |||
| * @param options | |||
| */ | |||
| private async getOpenAIEmbedding(input: string[]): Promise<number[][]> { | |||
There was a problem hiding this comment.
this is not a good solution.
This will break the return type of getTextEmbedding('large chunk')
There was a problem hiding this comment.
doesn't getTextEmbedding('large chunk') - it just ensures that getTextEmbedding('large chunk') is not throwing an exception
marcusschiesser
force-pushed
the
ms/truncate-embedding-tokens
branch
from
21d27b0
to
5ada8db
Compare
marcusschiesser
commented
Jun 11, 2024
marcusschiesser
force-pushed
the
ms/truncate-embedding-tokens
branch
from
8498f23
to
e6a26b9
Compare
|
let me ignore waku for now, it might be their issue |
himself65
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.