-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is there a way to disable logs(print statements)? #181
Comments
not for now (setting verbose=False is the safest bet but i know some indices still have print statements). i'll investigate how to make printing logs better. in the meantime you can do something hacky like this: https://stackoverflow.com/questions/8391411/how-to-block-calls-to-print |
Will you be interested in a PR for this? Do you have any preferred approach for something like this? I think a good way is to use the inbuilt logging module. |
@triptu would love your contribution if you have time! yeah i agree, i've so far taken the easiest route of printing but having an explicit logger might be useful (might also be good to think about what to do with the |
Going to tackle this @triptu please lmk if you have already started. Approach:
Notes: |
as of 0.4.0, this issue should be resolved |
@jerryjliu I do not think this is resolved yet. I still get the following logs:
When trying to change logging configuration, I get more logs, in addition to these (repeated). I even tried things like the following with no effects:
|
As of 0.4.29, root logger calls have been replaced with module logger calls. So you should see something like
In your logs now. To disable these you can add something like:
That will result in llama_index only logging warnings. If it's a specific submodule you can increase the verbosity specifically
|
* Add summarization task. * Reverted formatting changes in summarization.yml. * Fix test config. * Fix post-merge conflicts. * Update README.md Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com> * Update spacy_llm/tasks/templates/summarization.jinja Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com> * Incorporate feedback. Fix test issues. * Fix test issues. * Update spacy_llm/tasks/summarization.py Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com> * Incorporate feedback. * Incorporate feedback. * Extend IO test with custom field name. * Fix tests. * Add field arg to readme. --------- Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
No description provided.
The text was updated successfully, but these errors were encountered: