Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there a way to disable logs(print statements)? #181

Closed
triptu opened this issue Jan 7, 2023 · 7 comments
Closed

is there a way to disable logs(print statements)? #181

triptu opened this issue Jan 7, 2023 · 7 comments

Comments

@triptu
Copy link

triptu commented Jan 7, 2023

No description provided.

@jerryjliu
Copy link
Collaborator

not for now (setting verbose=False is the safest bet but i know some indices still have print statements). i'll investigate how to make printing logs better.

in the meantime you can do something hacky like this: https://stackoverflow.com/questions/8391411/how-to-block-calls-to-print

@triptu
Copy link
Author

triptu commented Jan 10, 2023

Will you be interested in a PR for this? Do you have any preferred approach for something like this? I think a good way is to use the inbuilt logging module.

@jerryjliu
Copy link
Collaborator

@triptu would love your contribution if you have time! yeah i agree, i've so far taken the easiest route of printing but having an explicit logger might be useful (might also be good to think about what to do with the verbose option scattered everywhere)

@yourbuddyconner
Copy link

yourbuddyconner commented Jan 26, 2023

Going to tackle this @triptu please lmk if you have already started.

Approach:

  • Think I am going to add a root logger (logging library) that gets pulled at class instantiation in the various base classes
  • Thinking of adding root logging config at the module level and removing all the verbose=True arguments everywhere
  • Will be able to set GPT_INDEX_LOG_LEVEL=foo as an environment variable or specify it in code.

Notes:

@jerryjliu
Copy link
Collaborator

as of 0.4.0, this issue should be resolved

@ibnesayeed
Copy link

@jerryjliu I do not think this is resolved yet. I still get the following logs:

INFO:root:> [query] Total LLM token usage: 101 tokens
INFO:root:> [query] Total embedding token usage: 1 tokens

When trying to change logging configuration, I get more logs, in addition to these (repeated).

I even tried things like the following with no effects:

with open(os.devnull, "w") as f, contextlib.redirect_stdout(f):
    index.query("<QUERY>")

@OliverFarren
Copy link
Contributor

As of 0.4.29, root logger calls have been replaced with module logger calls.

So you should see something like

INFO:llama_index.token_counter.token_counter:> [query] Total LLM token usage: 101 tokens
INFO:llama_index.token_counter.token_counter:> [query] Total embedding token usage: 1 tokens

In your logs now.

To disable these you can add something like:

logger = logging.getLogger('llama_index')
logger.setLevel(logging.WARNING)

That will result in llama_index only logging warnings.

If it's a specific submodule you can increase the verbosity specifically

logger = logging.getLogger('llama_index.token_counter')
logger.setLevel(logging.WARNING)

viveksilimkhan1 pushed a commit to viveksilimkhan1/llama_index that referenced this issue Oct 30, 2023
* Add summarization task.

* Reverted formatting changes in summarization.yml.

* Fix test config.

* Fix post-merge conflicts.

* Update README.md

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>

* Update spacy_llm/tasks/templates/summarization.jinja

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>

* Incorporate feedback. Fix test issues.

* Fix test issues.

* Update spacy_llm/tasks/summarization.py

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>

* Incorporate feedback.

* Incorporate feedback.

* Extend IO test with custom field name.

* Fix tests.

* Add field arg to readme.

---------

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants