Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouse as a vector store #10583

Merged
merged 9 commits into from Feb 15, 2024

Conversation

gingerwizard
Copy link
Contributor

@gingerwizard gingerwizard commented Feb 12, 2024

Description

ClickHouse support as a vector store.

ClickHouse can be used for vector search and is the basis of a number of other technologies such as MyScale. Approximate indices are experimental hence linear scan (fast in ClickHouse) is the default choice.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@gingerwizard gingerwizard changed the title clickhouse support ClickHouse as a vector store Feb 12, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gingerwizard gingerwizard marked this pull request as ready for review February 12, 2024 18:35
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 12, 2024
@gingerwizard
Copy link
Contributor Author

K the whole project struture changed. Working to ensure i adhere to the new format.

@logan-markewich
Copy link
Collaborator

@gingerwizard yea sorry about that, you just missed it by a day

Vector stores can be added under llama-index-integrations/vector_stores

There is a boilerplate script to help generate the initial package. The contributing guide has more details
https://github.com/run-llama/llama_index/blob/main/CONTRIBUTING.md

@gingerwizard
Copy link
Contributor Author

@logan-markewich yeh figured it out, code changes done. Ready for review.

@gingerwizard
Copy link
Contributor Author

@logan-markewich moved to BasePydanticVectorStore

@gingerwizard
Copy link
Contributor Author

@logan-markewich all tests pass, any chance of merging?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 15, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) February 15, 2024 22:58
@logan-markewich logan-markewich merged commit 9cc433a into run-llama:main Feb 15, 2024
8 checks passed
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants