Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix obj insert_nodes #11836

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix obj insert_nodes #11836

merged 1 commit into from
Mar 12, 2024

Conversation

logan-markewich
Copy link
Collaborator

insert_nodes would raise errors about unserializable objects

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 12, 2024
nerdai
nerdai approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! So if it's and obj store it in that dict map and set obj to None so it doesn't try to serialize it 💪🏽

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 12, 2024
@logan-markewich logan-markewich merged commit 6cd92af into main Mar 12, 2024
8 checks passed
@logan-markewich logan-markewich deleted the logan/fix_insert_nodes branch March 12, 2024 03:21
bdonkey added a commit to bdonkey/gpt_index that referenced this pull request Mar 12, 2024
@bdonkey
Merge branch 'main' into ssdev
a2538dd 
* main:
  add retries for openai LLM rate limit errors (run-llama#11867)
  Fix stream chat param error in CondenseQuestionChatEngine (run-llama#11856)
  Add logprobs field to `CompletionResponse` (run-llama#11855)
  Google readers integrations doc and drive updates (run-llama#11724)
  Adds llamafile support for local LLM and embeddings (run-llama#11709)
  Add QueryUnderstandingAgent LlamaPack (run-llama#11558)
  Split Google docs on headings (run-llama#11535)
  add baidu vectordb as vector store (run-llama#11494)
  [Feature Request]: add PowerPoint support to Confluence reader run-llama#10592 (run-llama#11454)
  add modelscope llm support (run-llama#11270)
  Add cohere command-R model (run-llama#11852)
  Fixed some gramatical mistakes  (run-llama#11840)
  fix obj insert_nodes (run-llama#11836)
  added table comment to Table Info in SQLDatabase (run-llama#11774)
  Fixes for add and delete Methods in LanceDBVectorStore (run-llama#11825)
  add support for open-mixtral-8x7b (run-llama#11792)
  Adds new LabelledSimpleDataset (llama-dataset) (run-llama#11805)
  Fix Cohere Embeddings issue run-llama#11820 (run-llama#11822)
  Update verifying connection (run-llama#11821)
  bump mistralai deps (run-llama#11819)
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
@logan-markewich
fix obj insert_nodes (run-llama#11836)
118722a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdai nerdai nerdai approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@logan-markewich @nerdai