Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RedisDocstore node retrieval from docs property #12324

Merged
merged 2 commits into from Mar 27, 2024

Conversation

aliozts
Copy link
Contributor

@aliozts aliozts commented Mar 27, 2024

Description

We cannot get docs from Redis docstore, detailed in the respective issue

Fixes #12319

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Not required for this.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Not required

Type of Change

Deleting decode

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 27, 2024
@aliozts aliozts changed the title delete decode Fix RedisDocstore node retrieval from docs property Mar 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 27, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) March 27, 2024 17:45
@logan-markewich logan-markewich merged commit 8b94b28 into run-llama:main Mar 27, 2024
8 checks passed
@aliozts
Copy link
Contributor Author

aliozts commented Apr 2, 2024

I should take a note that when I did update with pip install -U ... or uninstall and reinstalled the llama-index-storage-docstore-redis

pip install --no-cache-dir llama-index-storage-docstore-redis

it did not update the RedisKVStore

we should also do

pip install -U llama-index-storage-kvstore-redis

to make it work. apologies for the duplicate comment with the issue, did not know where to update. Thank you for the major help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Redis Docstore docs property error
2 participants