Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace redis driver with FalkorDB driver #12434

Merged
merged 6 commits into from Apr 3, 2024

Conversation

gkorland
Copy link
Contributor

Description

Replace redis driver with FalkorDB native python driver

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 30, 2024
@logan-markewich
Copy link
Collaborator

Seems like the new version of falkorDB requires python3.10 -- I'll update the BUILD file for CICD so that tests pass and reflect this requirement

@logan-markewich
Copy link
Collaborator

Or, I guess I can't push to this PR (must be a private fork)

To fix this
a) In llama-index-integrations/graph_stores/llama-index-graph-stores-falkordb/BUILD update it to look like this:

poetry_requirements(
    name="poetry",
    interpreter_constraints=["==3.10.*"],
)

b) In llama-index-integrations/graph_stores/llama-index-graph-stores-falkordb/pyproject.toml, bump the version from 0.1.2 to 0.1.3

@gkorland
Copy link
Contributor Author

gkorland commented Apr 1, 2024

We released a new version of the falkordb 1.0.4 client that supports python 3.8

@logan-markewich
Copy link
Collaborator

@gkorland oh awesome! :)

@logan-markewich
Copy link
Collaborator

@gkorland one final ask -- can you remove the changes from legacy (it's not meant to be modified) as well as bumping the version of this graph store integration package in the pyproject.toml (version = "0.1.3")

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 1, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 2, 2024
@gkorland
Copy link
Contributor Author

gkorland commented Apr 2, 2024

@logan pushed the changes

@logan-markewich logan-markewich merged commit 1d53dfe into run-llama:main Apr 3, 2024
8 checks passed
chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants