Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ImportError for 'MessageContentText' Due to Typing Update in openai.types.beta.threads #12437

Merged

Conversation

MaHDiaLaGaB
Copy link
Contributor

@MaHDiaLaGaB MaHDiaLaGaB commented Mar 30, 2024

Description

This pull request addresses a specific ImportError encountered due to a recent update in the openai.types.beta.threads library, which affected the import of MessageContentText. The issue was identified during routine development activities, highlighting a compatibility problem with the new library version. This fix updates the import statement to align with the latest library specifications, ensuring seamless integration and preventing import errors that were previously breaking our application's functionality.
Fixes #12424

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

…ssage" import

Updated the import statement to align with the new update in "openai.types.beta.threads", resolving the ImportError that prevented successful library usage.
…ssage" import

Updated the import statement to align with the new update in "openai.types.beta.threads", resolving the ImportError that prevented successful library usage.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 30, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 31, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 2, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) April 2, 2024 23:40
@logan-markewich logan-markewich merged commit b2e376a into run-llama:main Apr 3, 2024
8 checks passed
chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Import Error: cannot import name 'MessageContentText' from 'openai.types.beta.threads'
2 participants