Use recursive strategy by default for SharePoint #12557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the other readers (including OneDrive which is the most similar) use recursive file reading by default. Do the same thing here. Also treat empty strings as the value not being present.
dosubot
bot
added
the
size:S
logan-markewich
approved these changes
Apr 4, 2024
chrisalexiuk-nvidia
pushed a commit
to chrisalexiuk-nvidia/llama_index
that referenced
this pull request
Apr 25, 2024
Most of the other readers (including OneDrive which is the most similar) use recursive file reading by default. Do the same thing here. Also treat empty strings as the value not being present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the other readers (including OneDrive which is the most similar) use recursive file reading by default. Do the same thing here.
Also treat empty strings as the value not being present.
This is a breaking change— so definitely want to get your thoughts @logan-markewich and @nerdai