Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11389 (agent_react_multimodal_step.py bug) #12566

Merged

Conversation

mjschock
Copy link
Contributor

@mjschock mjschock commented Apr 4, 2024

Description

Explicitly declares the keyword variables for the _add_user_step_to_reasoning call in the MultimodalReActAgentWorker _run_step and _arun_step since the use of a partial was resulting in interpreting the first argument as the generate_chat_message_fn function.

Fixes #11389

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No - should I?

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense and I also tested the call in a notebook

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 4, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) April 4, 2024 19:25
@logan-markewich logan-markewich merged commit c24a296 into run-llama:main Apr 4, 2024
8 checks passed
chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: agent_react_multimodal_step.py bug and possible fix provided
2 participants