Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to load clip model from local file path #12577

Merged
merged 1 commit into from Apr 4, 2024

Conversation

chandrashekarvt
Copy link
Contributor

@chandrashekarvt chandrashekarvt commented Apr 4, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I was trying to use the llama-index-embeddings-clip integration package to load CLIP model from my local path and it was throwing an error saying its not a part of the available models of CLIP. I then checked the code and saw that the AVAILABLE_CLIP_MODELS was hardcoded and it just made a check if the model_name specified was a part of this AVAILABLE_CLIP_MODELS and so I figured it does not support loading models from local file path and I added that support.

Fixes # (issue)

  • Made a check if the model_name specified is a local file path and if so, allow it to be loaded.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 4, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) April 4, 2024 19:15
@logan-markewich logan-markewich merged commit ead7065 into run-llama:main Apr 4, 2024
8 checks passed
chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants