Coroutine-safe Spans #12589
Merged
Coroutine-safe Spans #12589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
| asyncio_mod = get_asyncio_module(show_progress=show_progress) | ||
| semaphore = asyncio.Semaphore(workers) | ||
|
|
||
| @dispatcher.async_span_with_parent_id(parent_id=parent_span_id) |
There was a problem hiding this comment.
So basically, anything span that spawns many jobs should use this decorator right?
There was a problem hiding this comment.
Yes with async that's right. The outer function to this should be decorated and we can extract the parent_id.
In fact, to be safe, we should use run_jobs() whenever we want to instrument the "simultaneous" execution of async tasks.
logan-markewich
approved these changes
Apr 7, 2024
chrisalexiuk-nvidia
pushed a commit
to chrisalexiuk-nvidia/llama_index
that referenced
this pull request
Apr 25, 2024
* add async task stack * just use asyncio.current_task * wip * delay asyncio Lock assignment in dispatcher * fix async unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
spansasync.gather()we should now use ourasync_utilsas that is decorated withdispatcher.spanand its nested (semaphore bounded) worker function is also decorated with the correctparent_id.asyncio.Lock()not being lazily constructed and thus breaks for jobs that don't have an async event loop.Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration